backport psbFromByteStringM and psbToByteArray to PinnedSizedBytes to 2.3.3.0#669
Merged
lehins merged 2 commits intoJul 8, 2026
Conversation
These were introduced in a newer commit that the wallet-cbits branch depends on but is not yet present in the tagged base this branch is rebased onto.
disassembler
force-pushed
the
sl/fix-cardano-crypto-wallet-backport
branch
from
73f7f1f to
bcd0bcc
Compare
disassembler
changed the base branch from
master
to
release/cardano-crypto-class-2.3.2.0
disassembler
changed the title
lehins
requested changes
Jul 6, 2026
lehins
left a comment
lehins
left a comment
Collaborator
There was a problem hiding this comment.
It is a bit unfortunate that there were already two major versions 2.4.0.0 and 2.5.0.0 released since 2.3.2.0, but conceptually it is not wrong to release 2.3.3.0 version and pretend like this functionality was removed in 2.4.0.0 only to be brought back in 2.5.1.0
Please make sure to bump up the version in cabal file and add a new section in the changelog with 2.3.3.0 header with changelog entries from 73339f4 and 31402fc
Other than that it looks fine to make a backport like this
lehins
changed the title
Add changelog entries and version bump for psbToByteArray and psbFromByteStringM, backported from 2.5.1.0.
lehins
merged commit 30b0259
into
release/cardano-crypto-class-2.3.2.0
21 of 24 checks passed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were introduced in a newer commit that the cardano-crypto-wallet branch depends on but is not yet present in the tagged base this branch is rebased onto.
Description
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)