Repository navigation
Conversation
jtniehof
added
Ins: CoDICE
jtniehof
force-pushed
the
codice_l3a_hi-direct-events-v2
branch
2 times, most recently
from
October 5, 2026 16:26
e92b334 to
4112d67
Compare
* Adding the incident_energy variable requires a new major version per SPDF
jtniehof
force-pushed
the
codice_l3a_hi-direct-events-v2
branch
from
October 5, 2026 16:37
4112d67 to
613719d
Compare
jtniehof
marked this pull request as ready for review
October 5, 2026 16:50
Collaborator
Author
|
This might conflict with #230 |
Collaborator
|
Closing due to #232, since I can't push to your fork (expected). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMAP-Science-Operations-Center/sds-data-manager#1699 should be merged immediately before this, so that reprocessed values are appropriately at major version 2.
Only imap_codice_l3a_hi-direct-events is affected...if we get this merged in time, it should be processed along with all the other ones flowing from the SPICE kernel updates.
Change Summary
Overview
Adding the
incident_energyvariable requires a new major version per SPDF. CoDICE team agrees that the new variable, plus updating the mass estimate to use that variable, warrants a major version bump.File changes
Just adding the
MODSgAttr incdf/config/imap_codice_l3a_global_cdf_attrs.yamlTesting
MODSisn't checked in other cases (e.g. GLOWS) so not added to unit tests, but verified the output. And it turns out the CoDICE integration tests do trip up if I get the formatting completely wrong :)