chore(viewer): remove dead code, hoist imports, trim Dataset Quality cards - #560
Open
omkargaikwad23 wants to merge 3 commits into
Open
chore(viewer): remove dead code, hoist imports, trim Dataset Quality cards#560omkargaikwad23 wants to merge 3 commits into
omkargaikwad23 wants to merge 3 commits into
Conversation
omkargaikwad23
force-pushed
the
chore/hoist-imports
branch
from
August 9, 2026 18:44
b00b71e to
f482cc5
Compare
omkargaikwad23
changed the title
This was referenced Aug 9, 2026
omkargaikwad23
marked this pull request as ready for review
August 10, 2026 04:54
omkargaikwad23
changed the title
Nothing imports it. It is a stale copy of main.py's State: 16 fields against 30, still carrying eval_summaries, and selected_main_tab defaults to "List" rather than "Status". Leaving it is a trap. @me.stateclass registers by class identity, so two decorated State classes are two different state objects to Mesop. The first module to import this one instead of main would get its own state with its own defaults, silently, with no error to trace.
…_ block The four local `import re` shadowed the module-level one added earlier; ast, threading and time each had a single use. The trends import stays local because trends imports from main. me.run does not exist in mesop 1.3.3, so the __main__ block only ever raised; gunicorn serves the module itself as `main:me`.
omkargaikwad23
force-pushed
the
chore/hoist-imports
branch
from
August 20, 2026 08:23
0e8b05d to
654a214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup plus one small UI removal. Four commits:
viewer/state.py(was chore(viewer): delete the unused state.py #558)__main__blockme.rundoes not exist in mesop 1.3.3, so the__main__block only ever raised;gunicorn serves the module itself as
main:me. Thetrendsimport stays localbecause
trendsimports frommain.The two Dataset Quality cards were the whole body of
_fleet_summary, and_stat_cardhad no other caller, so both helpers go with them. The per-row CUJscolumn and the detail report are unchanged.
Verification
I deployed this branch's image to GKE and verified the changes in the production
Mesop UI. This branch sits at the top of the stack, so that run exercises every
change in #553, #554, #555, #556 and #559 as well.