chore(viewer): delete the unused state.py - #558
Closed
omkargaikwad23 wants to merge 1 commit into
Closed
Conversation
Nothing imports it. It is a stale copy of main.py's State: 16 fields against 30, still carrying eval_summaries, and selected_main_tab defaults to "List" rather than "Status". Leaving it is a trap. @me.stateclass registers by class identity, so two decorated State classes are two different state objects to Mesop. The first module to import this one instead of main would get its own state with its own defaults, silently, with no error to trace.
Collaborator
Author
|
Folded into #560 along with the other pure-cleanup changes, to keep the stack to one cleanup layer. Same diff, no content lost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing imports it. It is a stale copy of main.py's State: 16 fields
against 30, still carrying eval_summaries, and selected_main_tab defaults
to "List" rather than "Status".
Leaving it is a trap. @me.stateclass registers by class identity, so two
decorated State classes are two different state objects to Mesop. The
first module to import this one instead of main would get its own state
with its own defaults, silently, with no error to trace.
Stack created with GitHub Stacks CLI • Give Feedback 💬