refactor(viewer): collapse five copies of get_results_dir into paths.py - #559
Open
omkargaikwad23 wants to merge 1 commit into
Open
refactor(viewer): collapse five copies of get_results_dir into paths.py#559omkargaikwad23 wants to merge 1 commit into
omkargaikwad23 wants to merge 1 commit into
Conversation
omkargaikwad23
force-pushed
the
refactor/shared-results-dir
branch
from
August 9, 2026 18:44
6f0a8ab to
33a5cf9
Compare
omkargaikwad23
changed the base branch from
chore/drop-dead-state-module
to
perf/handler-identity-cache
August 9, 2026 18:44
omkargaikwad23
marked this pull request as ready for review
August 10, 2026 04:53
omkargaikwad23
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
August 10, 2026 04:53
Four of the five were byte-identical; ai_comparer's had drifted, accepting a non-directory candidate and carrying an extra /evalbench/results entry that the repo-root candidate already resolves to inside the container.
omkargaikwad23
force-pushed
the
refactor/shared-results-dir
branch
from
August 20, 2026 08:23
33a5cf9 to
f069da2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four of the five were byte-identical; ai_comparer's had drifted, accepting a
non-directory candidate and carrying an extra /evalbench/results entry that the
repo-root candidate already resolves to inside the container.
Stack created with GitHub Stacks CLI • Give Feedback 💬