perf(viewer): cache List summaries instead of storing them in State - #553
Open
omkargaikwad23 wants to merge 1 commit into
Open
perf(viewer): cache List summaries instead of storing them in State#553omkargaikwad23 wants to merge 1 commit into
omkargaikwad23 wants to merge 1 commit into
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
omkargaikwad23
marked this pull request as ready for review
August 9, 2026 18:33
omkargaikwad23
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
August 9, 2026 18:33
omkargaikwad23
force-pushed
the
perf/list-summaries-cache
branch
from
August 20, 2026 08:12
34fcaac to
f20025e
Compare
State is serialized to the browser on every interaction, so keeping the whole parsed trends cache in `eval_summaries` made every click upload megabytes. Clicks that touched no data at all — switching to the Dataset Quality tab — could stall long enough to look like a hang. Parse into a module-level cache keyed on the trends cache mtime instead. Click payload drops to ~1.2 KB and repeat parses go from ~122ms to ~0.07ms. The cached list is shared across requests in a worker, so the sort now builds a new list rather than sorting in place.
omkargaikwad23
force-pushed
the
perf/list-summaries-cache
branch
from
August 20, 2026 08:23
f20025e to
bcfaa58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
State is serialized to the browser on every interaction, so keeping the
whole parsed trends cache in
eval_summariesmade every click uploadmegabytes. Clicks that touched no data at all — switching to the Dataset
Quality tab — could stall long enough to look like a hang.
Parse into a module-level cache keyed on the trends cache mtime instead.
Click payload drops to ~1.2 KB and repeat parses go from ~122ms to ~0.07ms.
The cached list is shared across requests in a worker, so the sort now
builds a new list rather than sorting in place.
Stack created with GitHub Stacks CLI • Give Feedback 💬