Repository navigation
Fix the lint errors @eslint/js 10's recommended rules raise - #168
Merged
Merged
Conversation
@eslint/js 10 adds preserve-caught-error and no-useless-assignment to its recommended set. Attach the caught error as `cause` where a catch rethrows a new Error, and drop two initialisers every path overwrites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed before the Dependabot bump in #156 can go in. That PR fails lint because
@eslint/js10 adds two rules torecommended:preserve-caught-error: inconfig.tsandengine.ts, a catch that throws a newErrornow passes the original error as{ cause: e }, so its stack trace isn't lost.no-useless-assignment: insavedObjects.tsanddebugConsole.test.ts, I removed an initial value that every path overwrites.There's no change in behaviour. I checked locally that
eslint .passes with both@eslint/js9 and 10. Once this merges, rebase #156 (@dependabot rebase).🤖 Generated with Claude Code