Repository navigation
fix: align the parser pin for Snowflake CREATE DATABASE batches - #178
Merged
Vedin merged 1 commit intoNov 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Supports Embucket/rustice#1176 and consumes Embucket/datafusion-sqlparser-rs#43.
Rationale for this change
Snowflake
CREATE DATABASE d; USE DATABASE dbatches lose their statement delimiter in the old parser. Rustice and Parquet must use the same parser source as DataFusion; updating only Rustice creates incompatible AST crate identities.What changes are included in this PR?
Update the workspace parser revision and its two lockfile source records from d6c2362 to 33e5ae26. No other dependency versions, edges, features or Rust code change.
Are these changes tested?
Local Rust 1.97 formatting and all-target/all-feature Clippy with
-D warningspass. The required extended workspace suite passes 10,761 tests with 10 ignored across 72 harnesses. The parser's all-features suite passes 1,553 tests with 7 ignored. Independent semantic comparison confirms every other manifest/lockfile package record and dependency edge is unchanged.Remote Rust, Dev, Dependencies and Large files workflows pass. Security audit reports 15 vulnerabilities for package versions unchanged by this pin-only change (job); no audit ignore or disabled check is introduced. This is a bounded parser fix, with the existing dependency-audit findings recorded separately. Downstream Rustice runtime/SDK qualification is tracked in apache#1176.
Are there any user-facing changes?
CREATE DATABASE batch delimiters are preserved. Targets the active Rustice compatibility branch.