Repository navigation
1.0.0 build 34: drop the redundant 中文 chip - #214
Merged
Merged
Conversation
Report 222 records why build 32 only passed the width case: Shift goes through flagsChanged rather than the menu action, and applyInputMode cancelled the composition before switching modes. Signed-off-by: wangzhizhou <824219521@qq.com>
Build 32 only fixed the width path because the keyboard Shift goes through flagsChanged and applyInputMode cancelled the composition before switching modes; both host paths are now recorded with their fix, the verification, and the lesson that one action usually has several entry points. Signed-off-by: wangzhizhou <824219521@qq.com>
The window can only appear while a composition is running, and English mode commits on every keystroke without ever composing, so the chip was always reading 中文 and only wasted about 36pt of header width (ADR-303). Removing it also lets the CandidateStatus.english field go; language feedback still arrives through the HUD when the window is hidden, and VoiceOver keeps announcing 语言：中文/英文. Build 34. Signed-off-by: wangzhizhou <824219521@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
用户观察：候选框出现时中英状态永远显示「中文」，按 Shift 切英文时候选框直接消失——那这枚芯片就是多余信息。确认属实后删除（ADR-303，报告 223）。
确认：结构性冗余，不是显示 bug
Session::handle_key首行if self.english { commit; return }—— 英文模式每键立即上屏，不建缓冲区composing只在非英文分支置真 → 英文模式下永远 falseshowCandidates只在isComposing分支被调用 → 候选窗不可能在英文态出现即：候选窗可见 ⇒ 必在中文输入 ⇒ 芯片恒为「中文」。
改动
CandidateStatus.chips：5 枚 → 4 枚（模式 / 全半角 / 简繁 / 标点）CandidateStatus.english字段与「语言：」无障碍分支InputController.candidateStatus()、Preview/main.swift、candidate-presentation、ui-snapshots不丢信息
中英切换仍弹 HUD（约 1.15 秒），VoiceOver 仍播报「语言：中文/英文」；其它四枚芯片不变。
验证
make verifyPASS；make macos-offline-tests56 文件 / 303 例 PASS装机后请看
打字出候选 → 顶部右侧应为 4 枚芯片（如
混输 半角 简体 。），比之前窄约 36pt。