Skip to content

feat(ui): Formula view — rebind, refresh baseline, review Atom, model pin as digest-bound proposals; order dev builds by commit time (#255) - #274

Merged
DanielNetzer merged 2 commits into
mainfrom
forgecell/issue-255-f0b4ee1676af56e7dd7a07df
Oct 27, 2026
Merged

DanielNetzer merged 2 commits into
mainfrom
forgecell/issue-255-f0b4ee1676af56e7dd7a07df

Conversation

@DanielNetzer

Copy link
Copy Markdown
Owner

Implements issue #255.

Molecule: mol-255-b08d6b8bbcf7bd1c20bc4c24
Formula: forgecell-github-issue
Base: 5a638555bff15af112ab3fa92ab4bb8ceacaee8e
Delivery: c5327979941c66257d0fb25bb78c90bc94e81c59

Awaiting exact-commit CI and human review. Harness-reported checks are not independent CI evidence. No merge, deployment or issue closure is authorized.

Daniel Netzer and others added 2 commits October 27, 2026 19:39
… pin as digest-bound proposals; order dev builds by commit time (#255)
…yID, rename proposalView to formulaProposalView

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DanielNetzer

Copy link
Copy Markdown
Owner Author

Adversarial review (2026-10-27): 2 HIGH + 1 MEDIUM, all fixed in this slice and confirmed by a verification pass:

  • Dev builds now record the source commit's committer time (git log -1 --format=%ct) in dev-build.json (0600, O_NOFOLLOW, owner and version checked on read); same-version dev builds are ordered by it only when both carry it, else unordered with a plain reason.
  • A launcher unrelated to the Formula's launcher needs an explicit anyway bound to the shown digest; the UI only accepts a launcher that resolves to a user-owned build under ~/.forgecell/releases or development; the diff names managed release / dev build / outside the managed tree.
  • Create refuses as stale (and dismisses) when the active Formula changed between show and prepare; a CLI decision between show and click is reported as already decided.

Merged main (f36a511) to resolve conflicts with #272 (setup) and #273 (next actions) in server.go and cli/ui.go (union of routes, fields and comments); deduplicated the identical assayID regex and renamed this slice's proposalView to formulaProposalView (clash with setup.go). Verified on the merged tree: build, vet, go test -count=1 for ui, cli, formula, install and onboarding.

@DanielNetzer
DanielNetzer marked this pull request as ready for review October 27, 2026 17:40
@DanielNetzer
DanielNetzer merged commit 2d05da0 into main Oct 27, 2026
2 checks passed
@DanielNetzer
DanielNetzer deleted the forgecell/issue-255-f0b4ee1676af56e7dd7a07df branch October 27, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant