Skip to content

Complete NuGet package metadata - #94

Merged
woksin merged 11 commits into
mainfrom
seo/package-metadata
Oct 24, 2026
Merged

woksin merged 11 commits into
mainfrom
seo/package-metadata

Conversation

@woksin

@woksin woksin commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Changed

@woksin woksin added the patch Bug fixes, docs, refactoring label Oct 20, 2026
@woksin woksin self-assigned this Oct 20, 2026
@woksin

woksin commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Packed (Release): Cratis.CritterStack.Screenplay. Nuspec verified: authors=Cratis, projectUrl=https://www.cratis.io/ (per row), MIT, readme README.md, icon logo.png, tags retained (existing integration-specific tags, per row). Shared props changed; logo.png copied from Arc. Screenplay.CritterStack.slnx Release build OK.

einari and others added 9 commits October 23, 2026 08:29
CodeQL is turned off across the Cratis organization, so its workflow and the shared configuration are removed.
Remove CodeQL code scanning
Use Specifications 5 with explicit shared lifecycle registration and net10-only spec execution while retaining all library Release target frameworks.

Pass the current test cancellation token to Roslyn and preserve ordered diagnostic comparisons across assertion-library equality semantics. Method-by-method parity retains the same three baseline failures.
Build before execution, validate fresh nonempty TRX results, and retain failed results for three days. Cover runner failures with 22 regression tests and document native execution and filtering.
Match the clean package consumer's exact version expectations to the packed dependency graph without removing any checks.

Replace retired nullable suffix spellings with canonical optional syntax, retaining explicit command, event, concept and query optionality assertions. All 1458 native Debug specifications pass with unchanged method and case counts.
Reference the canonical executable in both test configurations and compile its six reference-closure facts in Release. Keep all test bodies and assertions unchanged.

The exact native CI Release launcher now passes all 1458 methods with the same per-method case counts and outcomes as Debug.
@woksin

woksin commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator Author

Combined candidate: dbb6bd238c0b1819de9e3a34c2bf946e3a653106.

Fresh postmerge checks passed: whole-solution Release build with warnings as errors, package/API validation, metadata and packed framework-asset inspection, and isolated clean-cache package-consumer restore/build/execution. Library Release compilation retains .NET 8, 9 and 10. Consumer checks retain generation, source-range, exact dependency, no-Vogen and API/module-initializer assertions.

Native Debug and Release specifications each passed 1,458/1,458 at premerge migration commit 7052b03f47422d8f2a683e670a42add4a023f083, with exact class/method identities and case/outcome parity. Three stale nullable-spelling expectations were repaired while retaining semantic optionality assertions. Release now includes the canonical coverage previously guarded to Debug. Runner self-tests passed 22/22; actionlint and Code Health checks passed.

Those specification results are reused, not claimed as postmerge runs: the subsequent merge changed only descriptive package metadata and the logo, leaving source/test behavior, runtime dependencies, runner/workflow and compile conditions unchanged. Fresh build/pack/consumer checks cover the changed inputs.

Specifications now execute only on .NET 10; .NET 8/9-specific runtime behavior is no longer exercised, although all library targets still compile.

The complete combined change passed independent whole-change review with no findings. No local integration/Docker or fresh candidate CI result is claimed; PR CI must pass before merge.

@woksin

woksin commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator Author

Reviewer notes — update at 1babff3

Fixes the red Canonical Critter Stack Samples verify check (also red on main): the Screenplay printer now emits optional instead of ?. Seven .expected fixtures got new source-sha256 values and five ? → optional text assertions; no assertion was removed or loosened. Swapping optional back to ? in each new output reproduces the old hash exactly. All eight canonical samples passed locally (twice, byte-identical). Quick cross-provider review of the delta passed.

@woksin
woksin merged commit d7635c1 into main Oct 24, 2026
4 checks passed
@woksin
woksin deleted the seo/package-metadata branch October 24, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Bug fixes, docs, refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants