Repository navigation
Render report paths relative to the checked root - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First item of #68: reports name files relative to what was checked, so the output is stable across machines and code scanning services attach SARIF results to files.
test: define report paths relative to the checked root), implementation follows.Reportgains aroot: the directory checked, or the directory of the file checked.Report.locaterenders a path under the root relative to it, POSIX style, and leaves any other path as it is.app/views.py:3:5: …. JSON: relativelocation.pathand coverage paths, plus a top-levelrootso consumers can rebuild absolute paths. SARIF: the root is declared once as theSRCROOToriginal URI base and every location under it carriesuriBaseId; a location outside the root keeps its absolute URI without a base. Without a root, nothing changes.engine.report(findings, coverage, root); the CLI passes the resolved directory or the file's directory.Part of #68.