Repository navigation
Fail the check only from a chosen severity - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last item of #68: the exit status can follow a severity threshold.
test: define the severity threshold), implementation follows.Severity.rankorders the severities,infolowest,criticalhighest.--fail-on SEVERITYwith--check: every finding is still reported, the exit status is 1 only when a finding of that severity or above was reported. Without it any finding fails the check, as before. Suppressed and baselined findings never count. An unknown severity is rejected by the parser; the option without--checkis a usage error.high.With relative paths (#75), inline suppressions (#76), the baseline (#77) and this threshold, a repository with known findings can run the analyzer in CI and fail only on new findings at the chosen severity, with SARIF alerts attached to files.
Closes #68