Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix unhandled state exception in model failures #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

πŸ›‘οΈ Sentinel: [MEDIUM] Fix unhandled state exception in model failures #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,10 @@
1. Always replace `while (!exists(...))` retries with a bounded `for` loop (e.g., `for (attempt in seq_len(3))`).
2. Include an explicit check for the success condition inside the loop (`if (exists('model')) break`).
3. After the loop, verify success and fail securely with an explicit error (`if (!exists('model')) stop(...)`) to prevent unhandled exceptions downstream.

## 2024-06-25 - Unhandled State Error During Deterministic Model Failures
**Vulnerability:** When checking convergence or attributes on model objects (e.g. `!oldFormModel@OptimInfo$secondordertest`), if the object estimation inside a `try()` block failed, the object was never instantiated. This led to "object not found" runtime exceptions and potential internal state leakage in upstream evaluation pipelines if unhandled completely.
**Learning:** Checking properties of an object instantiated within a deterministic error block (like `try()`) requires ensuring the object itself actually exists before referencing its attributes. Failing to do so causes subsequent execution steps to fail ungracefully.
**Prevention:**
1. Always use `exists('object')` coupled with `isTRUE(object@property)` checks rather than directly referencing properties that might evaluate to a boolean check on a non-existent object.
2. In R scripts, explicitly prepend existence validations like `(!exists('oldFormModel') || !isTRUE(oldFormModel@OptimInfo$secondordertest))` before conditionally handling retries or throwing fallback errors.
34 changes: 17 additions & 17 deletions R/aFIPC.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ autoFIPC <-

if (tryFitwholeOldItems == T) {
if (
!oldFormModel@OptimInfo$secondordertest &&
(!exists('oldFormModel') || !isTRUE(oldFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand All @@ -208,7 +208,7 @@ autoFIPC <-
}

if (
!oldFormModel@OptimInfo$secondordertest &&
(!exists('oldFormModel') || !isTRUE(oldFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand Down Expand Up @@ -237,7 +237,7 @@ autoFIPC <-
}

if (
!oldFormModel@OptimInfo$secondordertest &&
(!exists('oldFormModel') || !isTRUE(oldFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand All @@ -255,7 +255,7 @@ autoFIPC <-
}

if (
!oldFormModel@OptimInfo$secondordertest &&
(!exists('oldFormModel') || !isTRUE(oldFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand All @@ -274,7 +274,7 @@ autoFIPC <-
}

if (
!oldFormModel@OptimInfo$secondordertest &&
(!exists('oldFormModel') || !isTRUE(oldFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand All @@ -293,7 +293,7 @@ autoFIPC <-
}

if (
!oldFormModel@OptimInfo$secondordertest &&
(!exists('oldFormModel') || !isTRUE(oldFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand All @@ -312,7 +312,7 @@ autoFIPC <-
}

if (
!oldFormModel@OptimInfo$secondordertest &&
(!exists('oldFormModel') || !isTRUE(oldFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
stop('Estimation failed. Please check test quality.')
Expand Down Expand Up @@ -398,7 +398,7 @@ autoFIPC <-

if (tryFitwholeNewItems) {
if (
!newFormModel@OptimInfo$secondordertest &&
(!exists('newFormModel') || !isTRUE(newFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand All @@ -422,7 +422,7 @@ autoFIPC <-
}

if (
!newFormModel@OptimInfo$secondordertest &&
(!exists('newFormModel') || !isTRUE(newFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand Down Expand Up @@ -451,7 +451,7 @@ autoFIPC <-
}

if (
!newFormModel@OptimInfo$secondordertest &&
(!exists('newFormModel') || !isTRUE(newFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand All @@ -469,7 +469,7 @@ autoFIPC <-
}

if (
!newFormModel@OptimInfo$secondordertest &&
(!exists('newFormModel') || !isTRUE(newFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand All @@ -488,7 +488,7 @@ autoFIPC <-
}

if (
!newFormModel@OptimInfo$secondordertest &&
(!exists('newFormModel') || !isTRUE(newFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand All @@ -507,7 +507,7 @@ autoFIPC <-
}

if (
!newFormModel@OptimInfo$secondordertest &&
(!exists('newFormModel') || !isTRUE(newFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
message(
Expand All @@ -526,7 +526,7 @@ autoFIPC <-
}

if (
!newFormModel@OptimInfo$secondordertest &&
(!exists('newFormModel') || !isTRUE(newFormModel@OptimInfo$secondordertest)) &&
!itemtype == 'ideal'
) {
stop('Estimation failed. Please check test quality.')
Expand Down Expand Up @@ -965,14 +965,14 @@ autoFIPC <-
}
}

# if(!LinkedModel@OptimInfo$secondordertest){
# if((!exists('LinkedModel') || !isTRUE(LinkedModel@OptimInfo$secondordertest))){
# message('Estimation failed. estimating new parameters with no prior distribution using quasi-Monte Carlo EM estimation. please be patient.')
#
# rm(LinkedModel)
# try(LinkedModel <- mirt::mirt(data = newformXDataK[colnames(newFormModel@Data$data)], LinkedModelSyntax, itemtype = newFormModel@Model$itemtype, SE = T, method = 'QMCEM', accelerate = 'squarem', technical = list(NCYCLES = 1e+5), pars = NewScaleParms, GenRandomPars = F))
# }
#
# if(!LinkedModel@OptimInfo$secondordertest){
# if((!exists('LinkedModel') || !isTRUE(LinkedModel@OptimInfo$secondordertest))){
# message('Estimation failed. estimating new parameters with no prior distribution using Cai\'s (2010) Metropolis-Hastings Robbins-Monro (MHRM) algorithm. please be patient.')
#
# try(rm(LinkedModel), silent = TRUE)
Expand All @@ -983,7 +983,7 @@ autoFIPC <-
# if (!exists('LinkedModel')) stop('Failed to estimate LinkedModel with MHRM after 3 attempts')
# }

# if(!LinkedModel@OptimInfo$secondordertest){
# if((!exists('LinkedModel') || !isTRUE(LinkedModel@OptimInfo$secondordertest))){
# stop('Estimation failed. Please check test quality.')
# }

Expand Down
Loading