This repository was archived by the owner on May 29, 2026. It is now read-only.
retrofit(rspec-2b): reverse-spec BackgroundJob cluster (14 methods / 5 files)#1804
Open
rubenvdlinde wants to merge 1 commit into
Open
retrofit(rspec-2b): reverse-spec BackgroundJob cluster (14 methods / 5 files)#1804rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
…5 files / 4 caps) Bucket 2b reverse-spec for the `backgroundjob` namespace-word cluster. Each of the 5 jobs implements a distinct task; split by behavior rather than minting a generic `background-jobs` umbrella capability. - faceting-configuration: NEW REQ for UUID-to-name cache pre-warmup (CacheWarmupJob + NameCacheWarmupJob) - workflow-operations: existing REQ-006 (Execution History Retention) back-annotated on ExecutionHistoryCleanupJob (no new REQ) - rapportage-bi-export: NEW REQ for ReportRenderJob — dashboard-driven schedule, missing-owner refusal, path-traversal rejection - zoeken-filteren: NEW REQ for SolrWarmupJob — post-import QueuedJob shape, availability gate, throughput metric 3 new REQs + 1 backfilled REQ across 4 capabilities. 14/14 methods annotated.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 162/162 | |||
| npm | ✅ | ✅ 532/532 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-24 21:58 UTC
Download the full PDF report from the workflow artifacts.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bucket 2b reverse-spec for the
backgroundjobnamespace-word cluster. Each of the 5 BackgroundJob classes implements a distinct task — split by observed behavior rather than minting a genericbackground-jobsumbrella capability (which would be a namespace-word anti-pattern).Capabilities touched (4 caps, 3 new REQs + 1 backfill)
CacheWarmupJob.php+NameCacheWarmupJob.phpfaceting-configurationExecutionHistoryCleanupJob.phpworkflow-operationsReportRenderJob.php(8 methods)rapportage-bi-exportSolrWarmupJob.php(3 methods)zoeken-filterenQueuedJobshape, availability gate, throughput metricWhy no
background-jobscapabilityTimedJob/QueuedJobis a Nextcloud framework hook, not a behavior. The 5 jobs do five different things:Naming a capability after the namespace would have hidden the actual contracts — including the security guards in
ReportRenderJob(missing-owner refusal + path-traversal rejection) that are easy to regress without an explicit REQ.Methods annotated (14/14)
CacheWarmupJob::run→ task-1NameCacheWarmupJob::run→ task-1ExecutionHistoryCleanupJob::run→ task-2ReportRenderJob::__construct,run,shouldRender,renderAndDeliver,writeToFiles,loadReportsRegister,loadDashboards,slugify→ task-3SolrWarmupJob::run,isSolrAvailable,calculateObjectsPerSecond→ task-4Observed gaps (advisory, not fixed)
ReportRenderJobcalls mappers with_rbac: false, _multitenancy: false— system cron context, but worth highlighting againstrapportage-bi-exportREQ-13 ("cross-register reporting respects RBAC boundaries").SolrWarmupJobuses\OC::$server->get(...)instead of constructor injection.CacheWarmupJob(DI'd) andNameCacheWarmupJob(service-locator) use different patterns for the same dependency — consolidation candidate.Test plan
@specannotationsReportRenderJobsecurity scenarios (missing owner,..path) match the code'sif ($owner === null)andif (str_contains($folderPath, '..'))guardsSource:
/tmp/or-scan/rspec-2b-backgroundjob.json(14 methods / 5 files, Bucket 2b).