This repository was archived by the owner on May 29, 2026. It is now read-only.
retrofit: reverse-spec modals Bucket 2b (entity-management + platform-administration)#1809
Merged
Merged
Conversation
…form-administration Reverse-engineer two new capabilities from src/modals/ Vue components: - entity-management-modals (3 REQs) — CRUD/bulk modal pattern over entity stores - platform-administration-modals (2 REQs) — settings + operational-task modals over /api/settings/* Annotate 49 real methods across 49 .vue files with @SPEC links to the matching task in retrofit-2026-05-24-2b-modals/tasks.md. Drops the 22 spurious "if" entries the scanner picked up from inline if-statements inside methods blocks.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 162/162 | |||
| npm | ✅ | ✅ 532/532 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-24 22:11 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mid-flight Phase 4a Bucket 2b retrofit that crashed on API-overload but had already committed substantive work. Opening PR for the committed work so it isn't lost.
What's in here
modalsdirectory cluster from Bucket 2b — Vue modal components grouped under 2 new capabilities (entity-management+platform-administration). See proposal.md + spec deltas inopenspec/changes/retrofit-2026-05-24-2b-modals/.Note
The agent crashed before its final summary report, so the per-method DROP audit may be incomplete relative to the other Bucket 2b PRs (#1800, #1801, #1804, #1806, #1807, #1808). Reviewer should compare bucket_2b methods against the annotations.
Test plan
openspec validate --strict)