fix: harden final v1.0.1 release gates#66
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f32562b27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| except (socket.gaierror, OSError): | ||
| pass | ||
| raise ValueError( | ||
| "cloud service URL could not be resolved" | ||
| ) from None |
There was a problem hiding this comment.
Preserve the cloud-session error contract on DNS failure
When a configured control or compute hostname has a transient DNS failure, this newly raised ValueError escapes callers that deliberately handle only CloudSessionError: for example, scripts/sync.py catches CloudSessionError around access_for_workspace() and will now emit a traceback instead of its documented connection error and exit code 2. Wrap this validation failure as CloudSessionError in the cloud-session boundary (or update those callers) so fail-closed validation remains a graceful operational failure.
Useful? React with 👍 / 👎.
Summary
Verification
This remains a draft pending private-cloud CI, operations evidence, and authorized canaries.