Repository navigation
fix(pi): bump hono and @hono/node-server overrides to clear audit gate - #333
Coding-Dev-Tools wants to merge 5 commits into
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Resolve the integrations/pi/package.json overrides conflict in favour of the patched hono 4.13.18 and @hono/node-server 2.1.8 floors that npm-shrinkwrap.json already resolves, so the lock and the declared overrides agree. Also close the two remaining coverage gaps around those overrides: - tests/test_release_infrastructure.py: assert the hono and @hono/node-server overrides and their locked version floors alongside the other pinned leaves. - integrations/pi/README.md: describe the hono and @hono/node-server leaves together with undici and minimatch. Verified: pytest tests/test_release_infrastructure.py tests/test_dashboard_vendor_assets.py, ruff check on the edited test, and in integrations/pi `npm run verify` plus `npm audit --omit=dev` (0 vulnerabilities).
|
Checked the override bump and the shrinkwrap diff. Keeping lockfileVersion 3 while limiting the change to hono and @hono/node-server is the right scope. One verification note worth adding: run the audit from a clean |
Summary
^4.13.13to^4.13.18and adds@hono/node-serveroverride^2.1.8inintegrations/pi/package.json.integrations/pi/npm-shrinkwrap.jsonwithnpm@11.12.1so only thehono(4.13.13 -> 4.13.18) and@hono/node-server(2.1.5 -> 2.1.8) blocks are updated (lockfileVersion: 3preserved).npm audit --omit=dev/npm audit --no-package-lock --include=dev) caused by GHSA-qv5m-9pm6-hqp3, GHSA-jpvv-r467-5p4w, GHSA-4m76-xfj5-7975, GHSA-h7mg-cq63-vhpq, GHSA-3gg2-335m-rxc6, GHSA-46wx-v44x-9hh2, and GHSA-4h7h-rv7c-7m2v.Verification
npm ci --ignore-scripts(inintegrations/pi): 0 vulnerabilitiesnpm run verify(inintegrations/pi):tsc --noEmitpassed, 23/23 unit tests passed,npm pack --dry-runpassednpm audit --omit=dev&npm audit --no-package-lock --include=dev: 0 vulnerabilitiespytest tests/test_release_infrastructure.py tests/test_dashboard_vendor_assets.py: 33/33 passed