Skip to content

fix(pi): bump hono and @hono/node-server overrides to clear audit gate - #333

Open
Coding-Dev-Tools wants to merge 5 commits into
mainfrom
fix/pi-hono-audit-overrides
Open

Coding-Dev-Tools wants to merge 5 commits into
mainfrom
fix/pi-hono-audit-overrides

Conversation

@Coding-Dev-Tools

@Coding-Dev-Tools Coding-Dev-Tools commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

Verification

  • npm ci --ignore-scripts (in integrations/pi): 0 vulnerabilities
  • npm run verify (in integrations/pi): tsc --noEmit passed, 23/23 unit tests passed, npm pack --dry-run passed
  • npm audit --omit=dev & npm audit --no-package-lock --include=dev: 0 vulnerabilities
  • pytest tests/test_release_infrastructure.py tests/test_dashboard_vendor_assets.py: 33/33 passed

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-14T01:27:25.658483Z
We couldn’t complete this review. Comment @codex review to try again.
b0c2175 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Coding-Dev-Tools and others added 4 commits November 13, 2026 22:18
Resolve the integrations/pi/package.json overrides conflict in favour of the
patched hono 4.13.18 and @hono/node-server 2.1.8 floors that npm-shrinkwrap.json
already resolves, so the lock and the declared overrides agree.

Also close the two remaining coverage gaps around those overrides:
- tests/test_release_infrastructure.py: assert the hono and @hono/node-server
  overrides and their locked version floors alongside the other pinned leaves.
- integrations/pi/README.md: describe the hono and @hono/node-server leaves
  together with undici and minimatch.

Verified: pytest tests/test_release_infrastructure.py
tests/test_dashboard_vendor_assets.py, ruff check on the edited test, and in
integrations/pi `npm run verify` plus `npm audit --omit=dev` (0 vulnerabilities).
@Coding-Dev-Tools

Copy link
Copy Markdown
Owner Author

Checked the override bump and the shrinkwrap diff. Keeping lockfileVersion 3 while limiting the change to hono and @hono/node-server is the right scope.

One verification note worth adding: run the audit from a clean npm ci rather than an existing node_modules tree, so a stale transitive cannot mask the result. Otherwise this looks like a clean security-only bump.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant