Repository navigation
Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 3 | Quote generator app #1520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MattCarolus10
wants to merge
11
commits into
CodeYourFuture:main
Choose a base branch
from
MattCarolus10:Module-data-group-sprint-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14
−2
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8531191
object prep
MattCarolus10 e06f169
Add console log to test pickFromArray with quotes array
MattCarolus10 7d614be
Fix HTML doctype and update title for quote generator app
MattCarolus10 aab7559
Display a random quote in the quote generator app
MattCarolus10 faa4b47
Display author name alongside the selected quote in the quote generat…
MattCarolus10 fd0e859
Refactor quote display logic into showQuote function
MattCarolus10 9edde22
Call showQuote function to display a random quote and author
MattCarolus10 2633348
Add event listener to generate a new quote on button click
MattCarolus10 fee3a39
Add comment to verify random quote selection using pickFromArray
MattCarolus10 0cd676c
Add interval to automatically display a new quote every 5 seconds
MattCarolus10 a795949
Remove prep from quote generator branch
MattCarolus10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requirements for this project are that it shows a quote on load, and optionally has a button you can click to have it auto-play more quotes.
I don't see a button in your UI when I load it, but it does auto-play quotes from the time it loads.
Can you work out how to gate this behaviour behind clicking a button, rather than just always doing it?