Repository navigation
Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 3 | Quote generator app - #1520
MattCarolus10 wants to merge 11 commits into
Conversation
|
The CYF AI reviewer had no comments to leave - please wait for a volunteer to review this PR. |
|
The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look. |
illicitonion
left a comment
There was a problem hiding this comment.
This generally looks good, but there's one comment to address - well done!
| showQuote(); | ||
|
|
||
| document.getElementById("new-quote").addEventListener("click", showQuote); | ||
| setInterval(showQuote, 5000); |
There was a problem hiding this comment.
The requirements for this project are that it shows a quote on load, and optionally has a button you can click to have it auto-play more quotes.
I don't see a button in your UI when I load it, but it does auto-play quotes from the time it loads.
Can you work out how to gate this behaviour behind clicking a button, rather than just always doing it?
Self checklist
Task code
CYF-1096
Changelist
Quote generator: title set, showQuote() renders a random quote and author, working button and 5s auto-play