Repository navigation
Fix 7 check-standards violations in openshell-provider diff (#129) - #130
Merged
Merged
Conversation
added 2 commits
October 12, 2026 18:34
Extract duplicated timeout SIGTERM normalization into settleTimeoutResult helper; lift termination settle into settleAfterTermination (22->15 lines); fix 2-tab mis-indent; rewrap 3 long test lines. Regenerate code-standards baseline in same change (ratchet tightens 23599->23595). check-standards: exit 0, all baselined tsc --noEmit: exit 0 openshell-provider.test.ts: 15/15 pass
w4ffl35
pushed a commit
that referenced
this pull request
Oct 13, 2026
…eline Cycle enumeration used codeintel graph order (raw readdir order, differs per checkout); DFS done-pruning then reported different cycle sets for identical graphs, failing the ratchet on fresh clones (PR #130 CI). Sort nodes and adjacency lists; pin canonical output with a diamond fixture test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework cycle 1 for #129: extracts duplicated timeout SIGTERM normalization into settleTimeoutResult helper, lifts termination settle into settleAfterTermination (22->15 lines), fixes mis-indent, rewraps 3 long test lines. Regenerates baseline ratchet in same change (23599->23595). check-standards exit 0, tsc exit 0, openshell-provider.test.ts 15/15 pass.