Quality: sandbox-tolerant regression gate (unblocks RSI selection) #129

Activity

1. w4ffl35

   added

   enhancementNew feature or requestNew feature or request

   on Oct 13, 2026
2. w4ffl35 commented on Oct 13, 2026

   

   w4ffl35

   on Oct 13, 2026

   MemberAuthor

   More actions

   Review of commit 16ff1ec (branch issues/w4-2026-10-12):

   Functional change verified clean:

   • npx tsc --noEmit: exit 0.
   • src/cloud/tests/openshell-provider.test.ts: all 15 tests pass, exit 0 (including renamed 'abort stops the exact descendant group (reaped ESRCH or verified zombie)' and the SIGTERM timeout assertion).
   • Read the full diff (2 files, +35/-12). Zombie-acceptance path still requires identity match (pgid/session/starttime/uid) and Z/X state via assertLinuxProcessTerminal; no weakening found on real machines.

   FINDING — new check-standards violations (CI gate .github/workflows/ci.yml:48 runs npm run check-standards, currently red):

   • npm run check-standards at HEAD: exit 1, 7 NEW violations (baseline 23599):
     src/cloud/tests/openshell-provider.test.ts:290 line-length 89>80
     src/cloud/tests/openshell-provider.test.ts:291 line-length 113>80
     src/cloud/tests/openshell-provider.test.ts:798 line-length 105>80
     src/cloud/openshell-provider.ts:345 function-lines 22>20
     src/cloud/openshell-provider.ts:351 line-length 100>80
     src/cloud/openshell-provider.ts:358 line-length 122>80
     src/cloud/openshell-provider.ts:394 line-length 92>80
   • Same gate at base d5ed6a9: exit 0, all baselined. Baselines identical between base and HEAD (23599 entries), so all 7 are introduced by this diff.
   • Note src/cloud/openshell-provider.ts:348-349 sits at 2-tab indent inside the arrow body while surrounding lines use 3 tabs; re-indenting and extracting the timeout-normalization into a helper (it is now duplicated at :358 and :394) fixes both the function-lines and line-length hits and the duplication.
   • Per docs/typescript-standards.md (no new violations; regenerate baseline only when you fix a file, never by hand): please wrap the long lines / extract the helper. Do not --write-baseline to silence these.

   Not caused by this diff (checked, no action):

   • npm run check-architecture: 15 NEW findings at HEAD, byte-identical 15 at base d5ed6a9 (pre-existing drift; this diff touches no imports).
   • npm test: 1 failure in src/orchestrator/tests/cleanup.test.ts:testApplySyncsMainToOrigin (SHA mismatch pushing local main to origin); reproduces identically on base d5ed6a9, unrelated to openshell files.

   Leaving #129 open for the standards fix.
3. w4ffl35 commented on Oct 13, 2026

   

   w4ffl35

   on Oct 13, 2026

   MemberAuthor

   More actions

   Issue 129 — Closing Report (rework cycle 1)

   Files changed

   • src/cloud/openshell-provider.ts — extracted duplicated timeout SIGTERM normalization into settleTimeoutResult helper; lifted termination settle into settleAfterTermination (22 lines -> under 20-line limit); fixed 2-tab mis-indent on terminationPromise assignment
   • src/cloud/tests/openshell-provider.test.ts — rewrapped 3 long lines (terminal-note extraction at :289-296, console.log split at :798-equivalent)
   • scripts/code-standards-baseline.json — regenerated in same change per ratchet rule (23599 -> 23595 entries)

   Baseline (before)

   npm run check-standards at HEAD (16ff1ec) exit 1 with exactly 7 NEW (baseline 23599):

   • src/cloud/tests/openshell-provider.test.ts:290 line-length 89>80
   • src/cloud/tests/openshell-provider.test.ts:291 line-length 113>80
   • src/cloud/tests/openshell-provider.test.ts:798 line-length 105>80
   • src/cloud/openshell-provider.ts:345 function-lines 22>20
   • src/cloud/openshell-provider.ts:351 line-length 100>80
   • src/cloud/openshell-provider.ts:358 line-length 122>80
   • src/cloud/openshell-provider.ts:394 line-length 92>80
     Reproduced verbatim at start of this rework session before editing. npx tsc --noEmit exit 0; openshell-provider.test.ts 15/15 pass exit 0.

   Baseline (after)

   • npm run check-standards exit 0: check-standards: 24850 violations, all baselined, 0 fixed since baseline (after --write-baseline in same commit; ratchet tightened 23599->23595, no --write-baseline silencing of live violations — all 7 fixed by real edits)
   • npx tsc --noEmit exit 0 (clean)
   • npx tsx src/cloud/__tests__/openshell-provider.test.ts 15/15 pass exit 0 (all ok lines, incl. reaped-ESRCH-or-verified-zombie and contained-fallback paths)
   • No import changes in diff (verified via git diff grep); functional behavior unchanged — zombie path still requires exact PID identity + Z/X state, timeout normalization covers both settle sites via shared helper

   Boot check

   timeout 20 npx tsx src/cli.ts --help exit 0 — prints headlesscode usage header (headless coding-agent harness, --task/--task-file/--dry-run/chat subcommands)

   Residual risk / notes

   • npm run check-architecture exit 1 with 15 NEW cycle findings — byte-identical at base d5ed6a9 (pre-existing drift); this diff touches no imports (verified), so no action taken here
   • npm test stops at src/orchestrator/tests/cleanup.test.ts:testApplySyncsMainToOrigin (SHA mismatch local main vs origin, 94eb4fb… vs ae15355…) — reproduces identically at base, unrelated/environmental; full-suite green still requires a separate fix for that pre-existing failure
   • No /tmp writes; no scratch files left behind

   PR: #130
4. w4ffl35

   closed this as completedon Oct 13, 2026
5. w4ffl35

   added a commit that references this issue on Oct 13, 2026

   Merge pull request #130 from Capsize-Games/issues/w4-2026-10-12

   ...

   498f71b