Fix #756: Correct malformed UPDATE SET clause in notify list delete - #794
Open
bmfmancini wants to merge 2 commits into
Open
Fix #756: Correct malformed UPDATE SET clause in notify list delete#794bmfmancini wants to merge 2 commits into
bmfmancini wants to merge 2 commits into
Conversation
The host email reset query in the notify list delete action (drp_action == 1) used 'AND deleted=""' as part of the SET clause instead of the WHERE clause, causing the deleted filter to be ignored and potentially producing unintended updates. Moved the deleted filter from SET to WHERE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #756
In
notify_lists.php, the bulk delete flow (drp_action == 1) contained a malformed SQL statement for the host email reset:The
AND deleted=""was incorrectly placed in theSETclause as part of the assignment expression, rather than in theWHEREclause as a filter condition.Impact
deleted=""filter was not applied as intended.Fix
Moved the
deleted=""filter from theSETclause to theWHEREclause, matching the structure of the adjacentthold_send_emailupdate queries in the same function:Testing
php -l notify_lists.php— no syntax errors.thold_send_emailupdates immediately above it in the same delete path.