Skip to content

Bug: notify list delete action uses malformed UPDATE SET clause for host email reset #756

Description

@somethingwithproof

Summary

notify_lists.php bulk delete action (drp_action == 1) contains a malformed UPDATE statement for the host email reset:

UPDATE host
SET thold_host_email = 0
AND deleted=""
WHERE ...

The AND deleted="" was incorrectly placed in the SET clause as part of the assignment expression, rather than in the WHERE clause as a filter condition.

Impact

  • The deleted="" filter was not applied as intended.
  • The expression semantics were incorrect and could silently produce unintended updates.

Location

  • notify_lists.php, bulk delete flow (drp_action == 1).

Expected

Move the deleted="" filter from the SET clause to the WHERE clause, matching the structure of the adjacent thold_send_email update queries.

Fix

Implementation in #794.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions