Repository navigation
feat(mobile): show the computer's own icon after chat names - #2499
Merged
Merged
Conversation
Chat rows used a generic computer mark after the name. They now use the computer's chosen icon and colour from Customize computer, so chats from different places are easy to tell apart in All. Cloud chats keep the cloud mark. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014UiRXqKRSQS39KzeJJnLcA
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014UiRXqKRSQS39KzeJJnLcA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014UiRXqKRSQS39KzeJJnLcA
Contributor
Author
|
Android phone result: PASS (Xiaomi, Android 16 / HyperOS 3, Dev debug build of this branch at 8e850ef with Metro, isolated QA Host) Screenshots: 2499-android/phone (commit b0c6729):
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Why the change
Since #2461 each computer has its own icon and colour, but chat rows still showed a generic computer mark after the name, so in All chats from different places looked alike.
Issue / Discussion: follow-up to #2461.
Special things to note
tsc,oxfmt, all mobile Vitest suites (+3 insource-name.test.tsx). Native iOS run on QA iOS 27 (Release app with this branch's JS bundle at 8e850ef, own isolated Host), covering feat(mobile): customize computers with a preset icon and colour #2461 and this PR: tab icon and underline colour, row icon and colour on DMs and groups, drawer tile, sheet Symbols/Emoji tabs, Theme colour restore, Reset confirm, name field above the keyboard, steady row layout while swiping. Not run: cloud rows (no cloud workspace on that Simulator) and Android (queued behind the Windows lane).Change outline
SourceNametakes an optionalHostLook; computer chats renderHostGlyphatmetasize tinted withhostColorInk(orsubtlewithout a colour).ConversationRow/ConversationRowFramepass the look through; Chats and Send to pass the saved computer's look.DESIGN.md(Conversation row) and a bilingual change fragment.🤖 Generated with Claude Code
https://claude.ai/code/session_014UiRXqKRSQS39KzeJJnLcA