Repository navigation
fix(mobile): keep Android tab icons sized with their labels under large text - #2507
Merged
Merged
Conversation
…ge text Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014UiRXqKRSQS39KzeJJnLcA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014UiRXqKRSQS39KzeJJnLcA
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change
With large system text on Android, the computer icon at the left of the Chats tabs is clipped instead of growing with the label / 安卓系统字体放大后,「聊天」顶部标签左侧的电脑图标被裁切,没有跟 label 一起放大。
Refs: follow-up to #2461 / #2499 (reported by Vain on a real Android phone).
Special things to note
expo-symbolsdraws Material Symbols as a fontText(fontSize: size) inside a fixedsize × sizeView. The Text follows the system font scale but the box doesn't, so at 2× text the glyph is twice its box and gets clipped.primitives/system-symbol(.android.tsxdivides the glyph size bytheme.fontScaleand keeps the box at the requested size).HostGlyphandRowIconnow use it, so settings row icons and the chat-row computer mark are covered too.meta.line × theme.fontScale, so they track the label; default size is unchanged.tsc --noEmit, newtest/system-symbol-android.test.tsxplus source-name / host-look / home-search / message-sheet-native / style-guard tests pass.pnpm lintpasses after the changelog link. Native screenshots (Android light/dark at default and max text) are queued on the shared device lane and will be added here.Change outline
src/ui/primitives/system-symbol{,.android}.tsx(new)HostGlyph,RowIcon→SystemSymbolenvironment-pager.tsx,host-look-editor.tsx: icon size ×fontScaleGenerated by Claude Code