Repository navigation
fix(mobile): hold the chat's bottom mask solid up to just under the composer capsule - #2456
Merged
Merged
Conversation
…omposer capsule The bottom fade curved from the screen edge to well above the composer, so with a tall draft it hid messages far above the capsule. Hold it solid up to space.x2 below the capsule's top whatever the line count, then clear it over edgeFade.bottom just above the capsule. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3dAFSSAHytUi4igDx3iwg
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
iOS 27 Simulator at fb01b34: pass. This ran in a Bot DM with long history, scrolled up, with the keyboard closed.
Generated by Claude Code |
With a tall draft the bottom mask's height rounded so the last pixel row of the screen showed message content under it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3dAFSSAHytUi4igDx3iwg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Requested by Vain · project thread
Why the change
With a 4-line draft the chat's bottom mask (#2398, softened in #2425) curves from the screen edge to
edgeFade.reachabove the composer, so it hides messages well above the capsule. Vain wants the line where messages are fully covered to sit just under the top of the composer capsule, at the same place for a 1-line or 4-line draft.Refs #2398, #2425
Special things to note
tsc,pnpm lint, mobile vitest (994 passed, 9 skipped). iOS 27 Simulator at fb01b34, keyboard closed, light and dark: empty composer and 4-line draft pass (messages readable up to the capsule's top, short fade only there). A 1px row at the very bottom showed content with the 4-line draft; 29cc6e8 overlaps the mask 1pt past the screen edge with its height rounded up (recheck pending). Not run: Android, keyboard-open states (the iOS 27 Simulator cannot show a software keyboard), large text.Change outline
EdgeFadetakes an optionalsolidlength (defaults to the safe-area inset as before), rounds its height up and overlaps 1pt past the screen edge.ConversationScreen: the bottom mask is solid from the screen edge tospace.x2below the capsule's top (composerHeight − space.x3 − space.x2), then clears overedgeFade.bottomabove that.DESIGN.mddescribes the new bottom mask; the navigation test expects the new fade height.🤖 Generated with Claude Code
https://claude.ai/code/session_01T3dAFSSAHytUi4igDx3iwg