Repository navigation
fix(mobile): remount the Android chat title when its theme or name changes - #2416
Conversation
…anges The floating header's title chip kept the width it was first measured at, so after switching between light and dark in the chat it clipped the Bot's name to its first letter. Keying the title on the scheme, font scale and name makes the native header measure it again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QxWnExdvT58a8MeXHJ7aRn
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QxWnExdvT58a8MeXHJ7aRn
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QxWnExdvT58a8MeXHJ7aRn
|
CI note: on Generated by Claude Code |
…nd screenshots Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Android phone result: name chip PASS; bottom fade still leaks on a coloured background (Xiaomi, Android 16 / HyperOS 3, release build of main 056d129) Screenshots: 2416-android-chat-chrome/phone (commit 2ef0671)
Finding: on a coloured chat background in dark, message text still shows through in the gesture-bar strip below the composer and between the + button and the input. The default dark background is clean. Follow-up #2425 softens the fades and needs its own phone check. Generated by Claude Code |
Requested by Vain · project thread
Why the change
Native QA of #2394 (Xiaomi, Android 16 / HyperOS 3) found a problem: after switching between light and dark while a chat is open, the floating header's title chip shrinks the Bot's name to "M…", even though there's plenty of room / #2394 真机 QA 发现:聊天页内切换浅色/深色后,顶部名称 chip 被截成 “M…”。
Refs #2394.
Special things to note
maxWidthcap as the iOS title item.height="100%"and kept its first, shorter height. Nothing more is changed for it here. A re-shot on current main is requested to confirm.pnpm typecheck✅ and the conversation screen tests ✅. Device verification pending, and this fix is a likely fix that hasn't been confirmed on a device yet.Change outline
headerTitle: () => title→headerTitle: () => <View key={scheme:fontScale:name} style={{ maxWidth }}>{title}</View>on Android.#2394 phone QA shots (before this fix):
.github/pr-screenshots/2394-android-chat-chrome/phone/on branchclaude/project-thread-m7tsnr-approvals.Generated by Claude Code