Add attitude, temperature and pressure to MultibeamPing - #285
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the MultibeamPing protobuf message so multibeam sonar pings can carry per-frame attitude and environmental readings (heading/pitch/roll, temperature, pressure) reported by the Oculus sonar, enabling downstream subscribers and .mbez dive logs to retain these values.
Changes:
- Added
heading,pitch,rollfields (tags 13–15) toMultibeamPing. - Added
temperatureandpressurefields (tags 16–17) toMultibeamPing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
follesoe
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
heading,pitch,roll(°),temperature(°C) andpressure(bar) fields (13–17) toMultibeamPing.OculusSimplePingResult), but they were never carried into the protocol, so they never reached subscribers or the.mbezdive log.Companion PR: BluEye-Robotics/libguestport (populates the fields from the Oculus driver).
Test plan
cross-imx-update): protoc accepts the new fields andlibblueyeprotocolbuilds and installs cleanly.🤖 Generated with Claude Code