fix(trigger-coolify-deploy): guard collateral-cancel status query - #12
Merged
Andreas-Garcia merged 1 commit intoSep 15, 2026
Merged
Conversation
…h set +e The mine_status curl call after cancel_phantom_builds() was unprotected, so a non-2xx response (curl exit 22) under set -euo pipefail hard-failed the whole deploy step instead of being treated as "not collaterally cancelled", matching how cancel_phantom_builds()'s own query already handles this. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Andreas-Garcia
deleted the
fix/trigger-coolify-deploy-mine-status-guard
branch
September 15, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancel_phantom_builds()cancels a native build, the follow-upmine_status=$(curl -sf ...)check (to detect whether that collaterally cancelled our own just-queued deployment) had no error handling, unlike the near-identical query insidecancel_phantom_builds()itself.set -euo pipefail, a non-2xx response from that GET (curl exit 22) hard-failed the whole deploy step instead of gracefully falling through.the-music-deck-admin's "Deploy API (preview)"/"Deploy showcase" checks failing withProcess completed with exit code 22right afterDeployment queued: .../Checking for a still-running native (webhook-triggered) preview build to stop....Changes
mine_statusquery inset +e/ capture exit status /set -e, same pattern ascancel_phantom_builds()'s own query.mine_statusas empty (i.e. assume not collaterally cancelled) rather than aborting.[Unreleased] / Fixed.Test plan