fix(trigger-coolify-deploy): guard status-poll curl against transient exit 22 - #13
Merged
Merged
Conversation
… exit 22 The deployment status polling loop's curl -sf | jq call was unguarded under set -euo pipefail, same class of bug as the mine_status check fixed in v4.3.2. A single non-2xx response (observed on the very first poll iteration in PR #253's preview deploy) hard-failed the whole action instead of retrying. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second instance of the exit-22 bug class fixed in v4.3.2 (#12): the deployment status polling loop's
curl -sf | jqcall was unguarded underset -euo pipefail. Observed live on PR #253's preview deploy — the very first poll iteration hit a transient non-2xx response and hard-failed the whole action instead of retrying.Changes
status=$(curl -sf ...)withset +e/exit-status capture, matching the existingcancel_phantom_builds()andmine_statusguard pattern.POLL_TIMEOUT_SECONDS) instead of aborting immediately.Test plan
🤖 Generated with Claude Code