Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 0 additions & 151 deletions .coderabbit.yaml

This file was deleted.

4 changes: 2 additions & 2 deletions src/arc403_interface/src/main.nr
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ use aztec::macros::aztec;
/// `noir-contracts/contracts/protocol_interface` packages (FeeJuice,
/// ContractInstanceRegistry), which use empty-bodied `#[aztec]` contracts for the same
/// purpose. The generated call interface depends only on function names, parameter
/// types, and the `#[external]` attributes never on bodies.
/// types, and the `#[external]` attributes - never on bodies.
///
/// The ARC-403 specification is a draft under active discussion:
/// https://forum.aztec.network/t/arc-403-authtoken/7887
/// This interface tracks the draft as implemented by the tokens in this repository and
/// may change if the specification changes.
///
/// The function bodies below are empty stubs this artifact exists to define the ABI,
/// The function bodies below are empty stubs - this artifact exists to define the ABI,
/// not to be deployed. WARNING: deploying this contract as-is and wiring it as a token's
/// `auth_contract` would produce an allow-all authorizer that never denies anything.
/// Implementations provide their own authorization logic (allowlists, KYC attestations,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,15 @@ pub unconstrained fn get_private_events_from_last_tx(

assert(
query_length <= MAX_PRIVATE_EVENTS_PER_TXE_QUERY,
"TXE query_length exceeds MAX_PRIVATE_EVENTS_PER_TXE_QUERY sync constants with aztec-nr txe_oracles",
"TXE query_length exceeds MAX_PRIVATE_EVENTS_PER_TXE_QUERY - sync constants with aztec-nr txe_oracles",
);

let mut events = BoundedVec::new();
for i in 0..query_length {
let len = event_lengths[i];
assert(
len <= MAX_EVENT_SERIALIZATION_LENGTH,
"TXE event payload length exceeds MAX_EVENT_SERIALIZATION_LENGTH sync constants with aztec-nr txe_oracles",
"TXE event payload length exceeds MAX_EVENT_SERIALIZATION_LENGTH - sync constants with aztec-nr txe_oracles",
);
events.push(BoundedVec::from_parts(raw_array_storage[i], len));
}
Expand Down
2 changes: 1 addition & 1 deletion src/vault_contract/src/main.nr
Original file line number Diff line number Diff line change
Expand Up @@ -1480,7 +1480,7 @@ pub contract Vault {
/// @notice Validates that the caller possesses authwit from the `from` address or the caller is the `from` address
/// @dev Deliberately NOT `#[authorize_once("from", "nonce")]`: that macro asserts `nonce == 0`
/// whenever `from == msg_sender`, which is sound for the token contracts (their nonce exists
/// only for the token-call authwit) but wrong here. The vault's `nonce` is dual-purpose it
/// only for the token-call authwit) but wrong here. The vault's `nonce` is dual-purpose - it
/// is forwarded as the authwit nonce of the inner token operations the vault performs on the
/// user's behalf (asset `transfer_public_to_public`, shares `burn_private`/`burn_public`).
/// A self-caller needs no VAULT authwit but still grants token authwits to the vault, and
Expand Down
2 changes: 1 addition & 1 deletion src/vault_contract/src/test/deposit_private_to_private.nr
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ unconstrained fn deposit_private_to_private_on_behalf_of_other_success() {
#[test]
unconstrained fn deposit_private_to_private_repeated_identical_self_deposits_distinct_nonces() {
// Regression guard for the vault's dual-use `nonce`: it is forwarded as the inner asset
// transfer's authwit nonce, so a SELF-caller must be able to pass a nonzero nonce distinct
// transfer's authwit nonce, so a SELF-caller must be able to pass a nonzero nonce - distinct
// nonces are what let two otherwise-identical private asset authwits both be consumed.
// This is why the vault does not use #[authorize_once("from", "nonce")], which asserts
// nonce == 0 whenever from == msg_sender and would revert both deposits below.
Expand Down
Loading