chore: drop unused CodeRabbit config, ASCII-ify .nr comments - #34
Open
alejoamiras wants to merge 1 commit into
Open
chore: drop unused CodeRabbit config, ASCII-ify .nr comments#34alejoamiras wants to merge 1 commit into
alejoamiras wants to merge 1 commit into
Conversation
CodeRabbit is not enabled on this repo; the config is defi-wonderland fork inheritance with no reviewer activity on any PR here. The six em-dashes in .nr sources were latent versions of the bug that broke CI on the ARC-403 docs PR: nargo's auto-generated assert messages mix byte and char offsets when slicing source spans, so any multi-byte character above a bare assert shifts its message by 2 and breaks exact-message tests. All .nr sources are now pure ASCII. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
alejoamiras
marked this pull request as ready for review
August 18, 2026 19:41
Benchmark Comparison
Contract: escrow
Contract: logic
Contract: multitoken
Contract: nft
Contract: token
Contract: vault
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two hygiene items from the cleanup arc:
.coderabbit.yamldeleted — CodeRabbit isn't enabled on this repo; the config is defi-wonderland fork inheritance with zero reviewer activity on any PR here..nrsources replaced with ASCII (arc403_interface/src/main.nr,vault_contract/src/main.nr, two test files). These were latent versions of the bug that broke Noir Tests on docs: correct ARC-403 mint semantics and disclose known trust boundaries #24: nargo's auto-generated assert messages mix byte and char offsets when slicing source spans, so any multi-byte character above a bareassertin the same file shifts that assert's message by 2 chars and breaks exact-message tests (self.storage...→lf.storage...). All currently inert — this prevents the trap from ever firing.srcis now verifiably pure ASCII.Comment-and-string-only changes; no behavior, ABI, or gate-count impact expected (the two reworded TXE guard strings are referenced nowhere else).
🤖 Generated with Claude Code