Simplify "What to do with running sites" dialog when quitting Studio#4140
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing 1b4bd11 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This was referenced Jul 9, 2026
Contributor
|
This is a good improvement - the previous dialog had too many choices and was hard to read. I tested it, and it works in general, but one case does not seem to be correct:
By selecting "stop site", I would expect that my site will be stopped, and will be kept stopped, as dialog doesn't say anything about auto-start. Instead, when I reopen Studio, the site starts automatically. Settings show "Stop, restart on next launch" option as selected. I think that having "Stop sites" saved in my case would be more logical. @shaunandrews any thoughts? |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
I pushed the mentioned changes to the branch. |
wojtekn
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Codex executed the implementation based on detailed instructions from me, informed by @shaunandrews's design spec in STU-1908.
Proposed Changes
#3837 changed the dialog Studio displays when quitting with running sites to look like this:
I argued in #3837 (comment) that this is too complex, and Shaun agreed. This PR changes the dialog to display a shorter text with fewer buttons again, along with a new dropdown in the Studio settings (and in the new agentic UI).
Testing Instructions
~/.studio/app.jsonand remove thequitSitesBehaviorpropnpm startnpm startagainapp.jsonto verify that the setting is persisted)ENABLE_AGENTIC_UI=true npm startapp.jsonto verify that the setting is persisted)Pre-merge Checklist