Simplify the quit-with-running-sites dialog and add a settings home for it#4125
Closed
shaunandrews wants to merge 2 commits into
Closed
Simplify the quit-with-running-sites dialog and add a settings home for it#4125shaunandrews wants to merge 2 commits into
shaunandrews wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
@shaunandrews, I didn't realize you had a PR for this (I didn't see anything in STU-1908). I put out #4140 this morning. Given that this PR is still in draft, I will go ahead and close it in favor of the other PR. Let me know if I'm missing anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Designed collaboratively in a Claude Code session (dialog copy and interaction explored against several alternatives), then implemented and ported to trunk by Claude. All changes reviewed by @shaunandrews.
Proposed Changes
The first time a new user quits Studio with a running site, they hit a native dialog that asks them to configure a three-way policy ("Keep running" / "Auto-start" / "Stop") explained by a bullet-list legend in the body text — a heavy, confusing decision at the exact moment they've decided to leave. And its "Don't ask again" checkbox wrote a preference that no UI exposed, so one click made the choice permanent.
This PR reframes the dialog as a single question the buttons can answer directly:
"Keep your sites running?" — Keep running (default) or Stop sites, with the running sites' names in the message so the stakes are concrete (falling back to a count when names are long or there are more than two).
No migration needed: the stored preference and its semantics are unchanged; existing saved choices (including auto-start) are honored as before.
Testing Instructions
ENABLE_AGENTIC_UI=true): Settings.Pre-merge Checklist
🤖 Generated with Claude Code