Repository navigation
build(deps): bound helia-edge below 0.8 - #73
Merged
Merged
Conversation
helia-edge 0.8 removes APIs, so the requirement is `helia-edge>=0.6.0,<0.8`; the lower bound and the locked version are unchanged. Refs #72
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependency and lockfile constraints are consistent and match the issue’s scope.
Review effort: Balanced
Findings: None
What changed in this PR
Bounds helia-edge below 0.8 to prevent installation of an incompatible release.
Changes:
- Updates the project dependency to
helia-edge>=0.6.0,<0.8. - Synchronizes the lockfile requirement.
| File | Description |
|---|---|
pyproject.toml |
Adds the upper dependency bound. |
uv.lock |
Mirrors the updated constraint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bounds the helia-edge requirement below 0.8:
helia-edge>=0.6.0,<0.8. The next helia-edge minor release (0.8.0) removes APIs, including the deprecated converters and interpreters, export recipes and the exporter registry. Without a bound, a fresh install could resolve to that release, which this package has not been tested with.pyproject.toml: the one requirement.uv.lock: the matching specifier.<0.8also admits helia-edge 0.7, which is not yet on PyPI. Every helia-edge name this package uses exists in the current helia-edge main; that check was static, not a test run.Testing
uv lock --checkfails with the new requirement and the old lock, and passes with the updated lock.Refs #72