Skip to content

Client tools: a client attaches tools to a conversation; collection-held conversations are kept #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbirAbbas merged 7 commits into from
Nov 3, 2026
Merged

Client tools: a client attaches tools to a conversation; collection-held conversations are kept #2334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
acec822
A client can attach tools to a conversation over the app wire
AbirAbbas Nov 3, 2026
daeeadb
Client tools ride at the tail of a conversation's belt
AbirAbbas Nov 3, 2026
696bc86
A conversation any collection holds is not blank-chat litter
AbirAbbas Nov 3, 2026
81d0314
codeaf app sends client tool calls to the connected app
AbirAbbas Nov 3, 2026
9d5b472
Change entry for client tools and collection-held conversations
AbirAbbas Nov 3, 2026
d5c4f9f
The client tools manual page is found by its own name
AbirAbbas Nov 3, 2026
c06d64d
Client tool registry follows the guard and name laws
AbirAbbas Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cmd/codeaf/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ func runApp(args []string) error {
services := openAppServices()
appServiceDoor.Store(services)
appWorkstreamAgents.Store(backend)
appClientToolsBackend.Store(backend)
backend.attachServices(services)
guard.Go("app/crews-start", func() { backend.crews() })
// THE APP IS AN OPEN WINDOW for as long as it runs, so the clock that runs
Expand Down Expand Up @@ -553,6 +554,7 @@ func appConnOf(client *remote.Client, release func(), assembled bool) *appConn {

// appBackend is the [appwire.Engine] over this process's conversations.
type appBackend struct {
clientTools appClientTools
chats appChats
pair appPair
drives *driveBook
Expand Down Expand Up @@ -1250,10 +1252,12 @@ func appRowOnDisk(id string) (session.SessionRow, bool) {
// A folder minted and never spoken in is still a conversation the app
// may have created; its meta names the workspace.
meta, err := session.LoadMeta(dir)
if err != nil || strings.TrimSpace(meta.ID) == "" {
if err != nil || meta.ID != id {
continue
}
return session.SessionRow{ID: id, AgentDID: meta.AgentDID(), Dir: dir, Transcript: transcript, Title: meta.Title, Workspace: meta.Workspace, Created: meta.Created}, true
return session.SessionRow{ID: id, AgentDID: meta.AgentDID(), Dir: dir, Transcript: transcript,
Title: meta.Title, Workspace: meta.Workspace, Owned: meta.Owned, Model: meta.Model,
Archived: meta.Archived, Spend: meta.SpentUSD, At: meta.Created, Created: meta.Created}, true
}
return session.SessionRow{}, false
}
Expand Down Expand Up @@ -4476,6 +4480,8 @@ func (b *appBackend) Close() error {
if b.leaving != nil {
b.leaving()
}
b.clientTools.disconnect()
appClientToolsBackend.CompareAndSwap(b, nil)
already := false
var crews *appCrewRun
var agents []*appAgent
Expand Down
Loading
Loading