Repository navigation
Client tools: a client attaches tools to a conversation; collection-held conversations are kept - #2334
Merged
Conversation
agents.tools_set attaches, replaces or removes one named set of tools on a conversation; agents.tool_call carries each model call to the client and agents.tool_result answers it. The hello says agents.client_tools. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A conversation with a client tool door offers the client's tools after every built-in, with each set's instructions on its own page and nothing added when no set is attached. Tools follow their declared category, a built-in name wins, and child tasks and discussions get neither tools nor instructions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Launch cleanup, the blank-chat sweep and the background places sweep keep a never-spoken conversation that a collection references, reading the collections database read-only and keeping the folder when it cannot be read. Opening such a conversation by id after a restart restores its owned, model, archive and spend facts from its metadata. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The app backend keeps each conversation's client tool sets for as long as the connection lasts, emits one agents.tool_call per model call and waits for the answer, its deadline, the turn's end or the connection closing. Call ids are stable for a replayed call, and a late or repeated answer is ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The registry's sender runs under guard.Go, every registry lock is released from a defer, and a test name no longer spells the old product name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A1a of the Workstreams move: workstream logic now lives in the desk, the engine stays the AI harness (design: the Workstreams plan's ARCH-DESIGN §1, row A1a).
Summary
crates/workstreams(workstreams-core), no Tauri types. One SQLite file per engine home (store_path:<app data>/workstreams/<16 hex of sha256(engine home)>/workstreams.db,WORKAF_WORKSTREAMS_DBoverrides) with canvas's habits:rusqlite 0.37bundled, WAL,user_versionmigrations underBEGIN IMMEDIATE, a newer file refused untouched, a 10 s writer wait mapped tobusy.nameandcollection_id), member-job claims (UNIQUE(factory, job)), pending creates, plans, pages with versions and deleted state, records, go-aheads, sources, suggestions, suggestion edits, wakes and wake items.Storemethods named like theBackendmethods, taking and returning the contract's serde types, with its errors (not_found,conflict,version_conflict+ detail,too_large,bad_params,in_other_workstream+ detail,cycle,busy), stage rule, size limits, Read-by-jobs defaults and go-ahead rules.EngineFactstrait, read outside any transaction;ChangeSinkreceives oneworkstream.changedper changed workstream after commit; page documents go through thePageDocseam (A1b's crate implements it).by_agent, agent page writes, proposals, suggestion create, source proposals; Done checked inside the write) and the wake store for A4 (begin_wakewith key dedup and daily caps,settle_wake,expire_wakes,parse_wake_answer).crates/core/src/engine/workstreams.rsinto the crate;ui2-corere-exports them, so no import changes. Outside the crate: the workspace member line, the core dependency line, the re-export andCargo.lock.Backendmethod is switched (A2 does that); no markdown renderer (A1b).Validation contract
tests/appworkstreams*.rs,pages.rs,records_goaheads.rs,sources.rs,suggestions.rs,wakes.rs,method_refusals.rs(each of the 36 methods: its ownnot_foundandbad_params)internal/workstream/*_test.go(store, pages, records/go-aheads, limits, sources, agent, agent-done, v0.2 fields, suggestions, wakes, wake answer, wake fix 1/2) and the store parts ofcmd/codeaf/appworkstreams*_test.go; each names its Go origin and contract itemvalidation.rsengine_facts_are_the_only_number_inputs_and_run_outside_locks,review_fix1.rsfinding 3validation.rsmigration_is_idempotent_across_store_handles,newer_schema_is_refused_without_changing_database_bytesvalidation.rsone_workstream_per_job_is_enforced_by_every_door_and_sqlite,store.rsownership testsvalidation.rskeep_grant_is_atomic_when_the_member_job_disappears,workstream_fields_v02.rskeep refusals and rollbacklimits.rs,validation.rsrow_and_page_parameter_bounds_refuse_atomically, source and suggestion capscontract_shapes.rs: readsdocs/workstreams-wire.mditself (examples and field tables), sends every example's params through the store, checks result, error and event shapes; fails on an unused example or a method with no caseReview: one fresh review round (2 major, 3 minor), all fixed with tests (
review_fix1.rs,method_refusals.rs).Left for others
PageDocfor A1b's crate and re-run the markdown-sensitive tests with it; feedEngineFactsfromcollections.open/factory.queue/agents.open; routeChangeSinkinto the engine-event delivery; create orchestration (pending_create,collections.create,agents.create, close an unused agent);claim_jobs/release_jobsoncollections.add/remove,replace_jobsat start;collections.renamefirst, thenset_name; origin-chat check; mapWorkstreamErrortoEngineError.begin_wake/settle_wake/expire_wakes; whether errand costs already land in the agent'sspent_usd(never count wake costs twice).Contract changes
None.
docs/workstreams-wire.mdis unchanged.🤖 Generated with Claude Code