Skip to content

[G01] Close broker token and handoff evidence gaps - #163

Merged
jjangg96 merged 4 commits into
mainfrom
codex/g01-management-token-lifecycle
Nov 3, 2026
Merged

jjangg96 merged 4 commits into
mainfrom
codex/g01-management-token-lifecycle

Conversation

@jjangg96

@jjangg96 jjangg96 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Outcome

Offline G01 broker evidence and recovery fixes for issue #1. This PR does not close issue #1: the issue stays open and Project #2 stays In progress until the live acceptance gates pass.

  • Require the exact reusable workflow run to remain in_progress at the authority checks.
  • Perform the final reusable-callee GET after constructing and signing the bounded handoff, immediately before durable handoff intent and child launch.
  • Persist management-token lifecycle intent before POST dispatch; revoke a known token once and close the lifecycle only after confirmed revocation plus durable records.
  • If attempt-journal sync fails in the pre-request callback, persist the known no-dispatch outcome to the account ledger. If that ledger write also fails, retain the fail-stop barrier.

Evidence

  • RED: TestBrokerExperimentV3ManagementRequestJournalFailureRecordsNoDispatch failed at prior source 51b167f65f600c8de48400c1e532e9a09976e02a: the next inspect was blocked even though the management-token POST had not been dispatched. It passes at this candidate.
  • Earlier RED evidence covers rejected/missing workflow status and final GET ordering before binding signing; those regressions pass at this candidate.
  • Go 1.27.3, with GOCACHE, GOMODCACHE and GOTMPDIR on /Volumes/worktree and module downloads disabled:
    • go test -race -p=1 -count=1 -timeout=300s ./... — PASS at this exact source (full suite not rerun during review).
    • go vet -p=1 ./... — PASS.
    • gofmt -d on changed Go files and git diff --check — PASS.
  • Hosted PR quick check: PASS at exact head aa4e8544eaf0ebb35d120d2b238c988b861a78ab (run 41691896174).
  • Full Public CI: runs after a source-affecting merge to main; not a pre-merge substitute.
  • Independent review: gpt-5.6-luna / max reviewed base fae718d307920ff60fda64e92b8b094a11af1753 and exact head aa4e8544eaf0ebb35d120d2b238c988b861a78ab. The reviewer found no P0–P3 source finding and confirmed the prior P2 is resolved. Its overall G01 disposition is HOLD solely because live G01 acceptance gates remain untested; that HOLD does not claim this offline PR completes G01.
  • Synthetic HTTP/subprocess fixtures only. No live GitHub provider, credential, runner, Scale Set, Docker or host operation was performed.

Incremental review ledger

  • Candidate: aa4e8544eaf0ebb35d120d2b238c988b861a78ab; broker management-token lifecycle, workflow status/handoff ordering, tests and evidence docs.
  • Finding resolved: Luna Max identified a P2 at 51b167f65f600c8de48400c1e532e9a09976e02a: a failed attempt-journal sync stopped the POST but left the account lifecycle pending. The regression reproduced the blocked later inspect; the fix records durable no-dispatch, retaining the barrier if that record cannot be synced.
  • Documentation count typo (“two” items, three listed) corrected in the same candidate.
  • Final delta sign-off: exact-head Luna Max review complete; no source findings. Its goal-level HOLD is recorded above and the remaining live gates stay open.
  • The candidate crosses authentication, protocol and resource-lifecycle boundaries; the fresh full Luna Max review was required and completed. GitHub Codex exact-head review (no findings) and hosted PR quick check (PASS) completed at this SHA.

Operational effect

No production provider or Scale Set implementation is added. Remaining G01 gates include production provenance and trust-root authority, broker-only execution, server-side conditional Scale Set cleanup, runtime/isolation/resource qualification, protected canary configuration, and an explicitly authorized Linux ARM64/JIT canary. The current canary configuration does not satisfy the checked-in protected-ref guard. No repo settings or workflow were changed and no canary was dispatched.

Rollback is a reviewed revert of this focused PR. It owns no production state or resources.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T18:16:17.448820Z aa4e854 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jjangg96

jjangg96 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: aa4e8544ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jjangg96
jjangg96 merged commit 325effa into main Nov 3, 2026
1 check passed
@jjangg96
jjangg96 deleted the codex/g01-management-token-lifecycle branch November 3, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant