Skip to content

fix: fix keepalive SendRequest hang when connection is closed#58

Merged
zx06 merged 1 commit into
mainfrom
fix-keepalive-deadlock
Jul 20, 2026
Merged

fix: fix keepalive SendRequest hang when connection is closed#58
zx06 merged 1 commit into
mainfrom
fix-keepalive-deadlock

Conversation

@zx06

@zx06 zx06 commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Fix SSH keepalive SendRequest deadlock by wrapping it in a channel-based select with a timeout. Under the new version of golang.org/x/crypto, SendRequest might hang indefinitely if the connection is closed.

@zx06
zx06 merged commit 92ec358 into main Jul 20, 2026
7 of 8 checks passed
@zx06
zx06 deleted the fix-keepalive-deadlock branch July 20, 2026 05:11
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.00%. Comparing base (c773a13) to head (bfdd2c8).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/ssh/client.go 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #58       +/-   ##
===========================================
+ Coverage   47.02%   83.00%   +35.97%     
===========================================
  Files          16       46       +30     
  Lines        1412     3706     +2294     
===========================================
+ Hits          664     3076     +2412     
+ Misses        655      473      -182     
- Partials       93      157       +64     
Flag Coverage Δ
e2e 47.02% <ø> (ø)
integration 47.02% <ø> (ø)
unittests 71.31% <90.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant