Repository navigation
fix: Get the name of the remote if there is more than 1 - #73
Merged
Merged
Conversation
aklt
changed the title
joelspadin
requested changes
Sep 7, 2026
joelspadin
left a comment
joelspadin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This looks like a good improvement. I just have a few suggestions to simplify the code and make it easier to read.
Document the `_get_tracking_remote` method Co-authored-by: Joel Spadin <joelspadin@gmail.com>
Contributor
Author
|
Thanks for your comments, I have updated this PR |
joelspadin
approved these changes
Sep 20, 2026
Collaborator
|
Fixed the formatting errors and verified it works for me as well. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
zmk downloadgave me the following error which this commit fixes: