Feat flat implementation - #865
Open
aloysiowinter wants to merge 8 commits into
Open
Conversation
The Oracle client had no CASE_CONFIG_MAP entry, so the web UI offered no index tuning inputs and every UI run fell back to defaults. Add the Oracle param names to CaseConfigParamType and expose IndexType (HNSW/IVF_FLAT/FLAT) plus the per-index parameters with the same conditional display pattern as pgvector.
… COSINE parse_oracle_metric silently fell back to COSINE for any unmapped MetricType (HAMMING, JACCARD, BM25), which would produce misleading recall numbers. Raise ValueError instead; None still means COSINE.
Import ordering, usedforsecurity=False on the md5 index-name hash, bare raise on re-raise, EM102/TRY400 exception message style, log the skipped vector_memory_size probe, prefer dict over a useless lambda, and drop the eager re-exports in oracle/__init__.py: all imports use fully qualified module paths (matching pgvector), and the eager 'from .oracle import Oracle' defeated the lazy oracledb import design.
- Relocate test_oracle.py to tests/ alongside every other client's tests. - Construct LabelFilter via label_percentage (label_value is a derived property) and use the derived label in the fixture data. - The IVF live test asserted the optimizer's plan used the vector index, which legitimately fails on a 100-row table; assert the index exists in user_indexes instead and keep the plan as informational logging. - Cover the new parse_oracle_metric ValueError.
feat: harden the Oracle client and expose its case configuration
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aloysiowinter The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
pgvectorFLATas a separate benchmark configuration for exact nearest-neighbor search in pgvector.Changes
pgvectorFLATconfiguration and CLI support.Validation
Manually validated with PostgreSQL + pgvector in Docker using
Performance1536D50K.1.0."index": "FLAT".