Skip to content

feat(valkey): add Valkey backend - #858

Open
bluayer wants to merge 2 commits into
zilliztech:mainfrom
bluayer:valkey-adapter
Open

feat(valkey): add Valkey backend#858
bluayer wants to merge 2 commits into
zilliztech:mainfrom
bluayer:valkey-adapter

Conversation

@bluayer

@bluayer bluayer commented Aug 24, 2026

Copy link
Copy Markdown

Summary

Adds a Valkey backend using valkey-glide-sync.

  • HNSW vector search
  • numeric and label filters
  • cluster and cluster-mode-disabled connections with TLS
  • configurable request and connection timeouts
  • pipelined inserts and prefix-scoped cleanup

@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bluayer
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bluayer

bluayer commented Aug 24, 2026

Copy link
Copy Markdown
Author

/assign @XuanYang-cn

Comment thread vectordb_bench/backend/clients/valkey/valkey.py Outdated
Comment thread tests/test_valkey.py

import numpy as np
import pytest
from glide_sync import Batch

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/test_valkey.py line:6
Low ---- This module-level import of glide_sync is only satisfied by the [valkey] extra, which CI does not install (pull_request.yml installs ".[test]" only), so these new tests cannot be collected in the standard test environment and are not exercised by make unittest or make lint. Consider pytest.importorskip("glide_sync") (or adding the valkey extra to the [test] dependency set) and wiring the tests into the CI test command so this substantial coverage can actually run.

@bluayer bluayer Aug 27, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yhmo Optional backend tests are not currently part of the standard PR CI, so Valkey backend also follows the existing convention. Is this a new requirement for all new backends?

Comment thread vectordb_bench/backend/clients/valkey/config.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants