feat: recreate /dev/userfaultfd inside the jail - #2
Merged
Conversation
Cloud Hypervisor OnDemand restore creates the uffd in-process after dropping privileges. Recreate the host character device and chown it to the jail UID so the VMM does not need vm.unprivileged_userfaultfd=1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud Hypervisor OnDemand restore creates the uffd in-process after dropping privileges. Recreate the host
/dev/userfaultfdcharacter device inside the jail and chown it to the jail UID so the VMM does not needvm.unprivileged_userfaultfd=1.This is the grant Cloud Hypervisor documents in snapshot_restore.md. Firecracker's external uffd-handler is out of scope.
Version bump: 0.1.10 → 0.1.11.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.