refactor: 清理死代码与冗余导出 - #17
Merged
Merged
Conversation
候选 4-6 落地后文档同步： - architecture：facade 签名 RelationRow→StoredRelation、延迟连接描述去掉已私有化的方法名 - relation-tool-redesign：接口记录同步 StoredRelation、er-diagram 标记为已移除 - test-plan/ai-runner：移除 er-diagram 用例（G11），G10 描述改为表结构文本 - mutation-tool-design：executeMutation 片段删除不可达的 timeout 选项
全仓库死代码审查： - 删除零引用的 showWorkspacePanel，连坐清理 sendUnconfiguredHint 与 db-workspace-panel 消息渲染器（唯一发送方已删） - 12 个仅模块内部使用的导出去 export（QueryOptions/QueryOutput/ MutationOutput/ConnectionConfig/ConnectionsFile/ConfigLoadResult/ FavoriteFilter/DocumentAudience/RenderOptions/MutationValidation/ BrowserContent/toRelatedTuiData 等），模块内聚、接口面收窄 - 4 处未使用变量：3 处参数加 _ 前缀（遵循既有 _kb 约定）， createConnection 删除完全冗余的 env 参数并同步调用点 - 临时开启 noUnusedLocals/noUnusedParameters 验证清零
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
全仓库死代码审查 + 文档同步
变更内容
refactor 清理（14 文件，+20/−124）：
showWorkspacePanel（switch.ts 76 行），连坐清理sendUnconfiguredHint与db-workspace-panel消息渲染器（唯一发送方已删）_前缀（遵循既有_kb约定）、createConnection删除完全冗余的env参数并同步调用点--noUnusedLocals --noUnusedParameters验证清零docs 同步（5 文件，+10/−13）：候选 4-6 落地后的文档现状对齐（StoredRelation、er-diagram 移除、executeMutation 片段）
为什么
8 个架构候选落地后，零引用导出、死函数与冗余参数沉淀在公开面上。清理后接口面更窄、模块更内聚（AGENTS.md"模块内部类型留在模块内"）。
验证
npm run check（tsc）+ 临时 noUnusedLocals 检查通过npm test241 通过npm run lint0 errors（12 warnings 存量）npm run fmt+fmt:check通过