Repository navigation
Conversation
Related to zarr-developers#348. Verify fixed float32/float64 data with registry-restored JSON configurations.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 905 905
=========================================
Hits 905 905 🚀 New features to boost your workflow:
|
Author
|
A quick update: the upstream Tests, Wheels, and i386 workflows have now passed for this PR. This is limited to BitRound compatibility fixtures and registry-restored decoding tests, with no production behavior changes. Could a maintainer take a look when convenient? I'd appreciate feedback on whether this coverage is a suitable step toward #348. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #348; this advances only the BitRound subtask.
BitRound's current tests exercise data produced by the current encoder. Add small
fixed compatibility data for float32/float64 and two explicit
keepbitsvalues,then decode it using the instance returned by
get_codecafter a JSON roundtrip.Assert the restored type/configuration separately from dtype, shape and exact
rounded values, since decoding does not depend on
keepbits.The four binary fixtures total 96 bytes and were established from commit
1f83681cf310ac9aac8041ed6ff4a5dcc42a7aad. Their README records the input,configuration, byte order, generation procedure and independently calculated
expectations. Tests only read these files and fail when required data is absent.
This adds compatibility coverage without changing production behavior, the
shared compatibility helper, or requirements on future encoder output.
Validation on Windows x86_64, Python 3.13.5, NumPy 2.5.4, with this checkout and
its C/Cython extensions built through Meson:
pytest -p no:zarrproduces the same result while avoiding Zarr's pytest pluginimporting Numcodecs before coverage starts. BitRound and registry coverage is
100%; total Python coverage is 99.34% (alternate CRC32C backend branches remain).
baseline copy; no new documentation warnings.
wrong decoded dtype/shape/values fail at the intended checks. After removing
substitutions, all four cases pass with encoding forbidden and fixture hashes
unchanged. These probes are outside the proposed patch.
The upstream cross-platform CI matrix has not been run for this patch.