Repository navigation
Fix stale rollout discovery and warning lifecycle for v2.7.3 - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale
threads.rollout_pathentries and normal directory supplementation were reported asstate_schemafailures on every scan, inflating occurrence counts and leaving recovered warnings visible indefinitely.Recover a stale path only when a unique same-name file in the current session/archive directories has a matching first session-metadata ID. Treat directory supplementation as normal discovery, keep genuinely unavailable sources actionable with recovery guidance, and reconcile discovery warnings after successful scans. Preserve unrelated accounting warnings, existing usage, and deduplication; invalidate dashboard caches when warning state changes.
Prepare v2.7.3 with localized warning labels, build/demo version updates, and release notes. Pin CI and release native macOS validation to macOS 15 (keeping both ARM and Intel release jobs) after the rolling macos-latest job remained unassigned for over ten minutes; retain all tests. No historical rebuild is required; deleted source files still require restoration from backups.
Validation: full
go test ./...,go vet ./..., race checks for usage/store/server, and all 28 Dashboard/Demo browser tests passed. Regressions cover moved/archived/Windows paths, unsafe metadata matches, warning resolution/counts/revisions, and localized UI labels.