Allow hyphen in alias, add "not found" response and fix jupyt#11
Open
savnadya wants to merge 1 commit into
Open
Allow hyphen in alias, add "not found" response and fix jupyt#11savnadya wants to merge 1 commit into
savnadya wants to merge 1 commit into
Conversation
futujaos
reviewed
Jun 22, 2026
| // picked up by the next discovery pass. Return 503 (transient) rather than 403, | ||
| // so the client retries instead of surfacing a scary "permission denied". | ||
| s.logger.Warnf("task not found during auth check (likely starting): %s", err) | ||
| return taskNotFoundResponse, nil |
Collaborator
There was a problem hiding this comment.
envoy's authz may consider all non-403 responses as "successfull auth", so this change may lead to upstreaming request to task
afaicr I encountered such a behavior, so this needs checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.