Skip to content

Address the lazy-load guard review - #596

Merged
KalimeroMK merged 3 commits into
yiisoft:masterfrom
KalimeroMK:lazy-load-guard-review
Oct 20, 2026
Merged

KalimeroMK merged 3 commits into
yiisoft:masterfrom
KalimeroMK:lazy-load-guard-review

Conversation

@KalimeroMK

Copy link
Copy Markdown
Contributor
Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues #595

Both points from @Tigrov in #595:

  • populate() decides on the query's asArray, so registerResultSet() no longer checks every model.
  • check() returns when the record has no registered result set, instead of giving it one of its own that can only ever reach a count of one. Records of a single-record query are still counted for getCounters().

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b9b7377e-e2a4-4818-a27f-891515aae856

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.70%. Comparing base (2fe1bad) to head (13c25a1).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #596   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
- Complexity      685      686    +1     
=========================================
  Files            47       47           
  Lines          1690     1691    +1     
=========================================
+ Hits           1685     1686    +1     
  Misses            5        5           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KalimeroMK
KalimeroMK requested a review from Tigrov October 20, 2026 10:43
@KalimeroMK
KalimeroMK merged commit 283302a into yiisoft:master Oct 20, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants