Repository navigation
match a wildcard only in the leftmost label in match_hostname - #2619
Merged
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildcard honoured outside the leftmost label in match_hostname
detail::match_hostnametreats any pattern label ending in*as a wildcard, so a certificate presentingwww.*.example.testauthenticateswww.evil.example.test, and*.*authenticates every two-label host; the Mbed TLS and wolfSSL backends route both their dNSName and CN comparisons through it. OpenSSL'sX509_check_host()already refuses a wildcard anywhere but the leftmost label (RFC 6125 6.4.3), so this restricts it the same way and leaves the deliberateprefix*form alone.SSLClientServerTest.TlsVerifyHostnameWildcardLabelcovers it against a newcert_wildcard_san.pem; it fails on Mbed TLS and wolfSSL before the change and passes on all three backends after.